Skip to content

build: drop sccache fallback; zccache is the only compile cache - #80

Merged
zackees merged 1 commit into
mainfrom
drop-sccache-fallback
May 13, 2026
Merged

zackees merged 1 commit into
mainfrom
drop-sccache-fallback

Conversation

@zackees

@zackees zackees commented May 13, 2026

Copy link
Copy Markdown
Member

Summary

Drop the residual sccache fallback in ci/env.py::_apply_rustc_wrapper. Soldr (via zccache) is the project's only compile cache; the sccache half was a leftover from the pre-soldr era and was already redundant once PR #79 closed #75.

After this change, grep -rn 'sccache\|SCCACHE' . returns zero hits across the tree.

Diff

 ci/env.py | 18 +++++++-----------
 1 file changed, 8 insertions(+), 10 deletions(-)

Test plan

  • bash lint — green
  • grep -rn 'sccache\|SCCACHE' repo-wide returns zero hits

Related

🤖 Generated with Claude Code

Soldr (via zccache) is the project's compile cache. The sccache
fallback in ci/env.py::_apply_rustc_wrapper was carried forward
from the pre-soldr era; with PR #79 (closing #75) it no longer
serves a purpose. Remove the fallback so RUSTC_WRAPPER points
only at zccache when set.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@zackees
zackees merged commit 09903e7 into main May 13, 2026
16 of 25 checks passed
zackees added a commit that referenced this pull request May 13, 2026
#81)

* build: drop sccache fallback; zccache is the only compile cache

Soldr (via zccache) is the project's compile cache. The sccache
fallback in ci/env.py::_apply_rustc_wrapper was carried forward
from the pre-soldr era; with PR #79 (closing #75) it no longer
serves a purpose. Remove the fallback so RUSTC_WRAPPER points
only at zccache when set.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* ci(lint): install rustfmt/clippy via rustup; relax test_version assert

Closes the two CI regressions that PR #80 surfaced on main:

1. **Lint job missing rustfmt and clippy.**
   zackees/setup-soldr@v0 reads only the channel from rust-toolchain.toml;
   the components array (["clippy", "rustfmt"]) is ignored. With the
   minimal profile, cargo fmt fails:
       error: 'cargo-fmt' is not installed for the toolchain
   Provision them explicitly via rustup component add after setup-soldr.
   Soldr itself does not yet expose component management — its CLI runs
   tools from the active toolchain but doesn't install missing components.

2. **test_version.py expects bare version string.**
   The Rust CLI (clap) emits 'fastled 2.0.7' for --version, matching the
   standard '<bin> <version>' format. The Python-era argparse emitted just
   '2.0.7'. Switch from assertEqual to assertIn so the package version is
   verified to be present without prescribing the exact format.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@zackees
zackees deleted the drop-sccache-fallback branch November 5, 2026 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Local dev cargo builds bypass soldr/zccache — slow rebuilds

1 participant